Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API ] Add some basic sanity checking when creating a dataset #1111

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[API ] Add some basic sanity checking when creating a dataset #1111

merged 2 commits into from
Nov 12, 2024

Conversation

jbygdell
Copy link
Collaborator

@jbygdell jbygdell commented Nov 1, 2024

Description
This adds some basic validation when creating a dataset

  • ensure that all files belong to the submission user
  • ensure that all accession IDs exists

How to test

@jbygdell jbygdell requested a review from a team November 1, 2024 10:34
@jbygdell jbygdell self-assigned this Nov 1, 2024
@jbygdell jbygdell force-pushed the feature/api-dataset-sanity-checking branch 2 times, most recently from 77ad56f to 9703f07 Compare November 4, 2024 09:40
MalinAhlberg
MalinAhlberg approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbygdell jbygdell force-pushed the feature/api-dataset-sanity-checking branch from 9703f07 to c12358c Compare November 4, 2024 13:34
@jbygdell jbygdell mentioned this pull request Nov 4, 2024
Merged
@jbygdell jbygdell force-pushed the feature/api-dataset-sanity-checking branch from c12358c to 268133d Compare November 5, 2024 14:34
@jbygdell jbygdell enabled auto-merge November 5, 2024 14:34
aaperis
aaperis approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jbygdell jbygdell added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 5275a20 Nov 12, 2024
20 of 21 checks passed
@jbygdell jbygdell deleted the feature/api-dataset-sanity-checking branch November 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaperis aaperis aaperis approved these changes

@MalinAhlberg MalinAhlberg MalinAhlberg approved these changes

Assignees

@jbygdell jbygdell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbygdell @MalinAhlberg @aaperis